Skip to content

fix: extend bounded cypher reentry carrier#975

Merged
lmeyerov merged 25 commits intomasterfrom
feat/cypher-master-tck-coverage-frontier
Mar 31, 2026
Merged

fix: extend bounded cypher reentry carrier#975
lmeyerov merged 25 commits intomasterfrom
feat/cypher-master-tck-coverage-frontier

Conversation

@lmeyerov
Copy link
Copy Markdown
Contributor

@lmeyerov lmeyerov commented Mar 30, 2026

Summary

  • add bounded vectorized Cypher reentry support for the same-alias MATCH ... WITH ... MATCH ... subset
  • carry identifier-style scalar projections through the bounded reentry path for trailing RETURN / ORDER BY
  • harden the compiler/runtime contract around seed ordering, null-id alignment, renamed aliases, and hidden-column collisions
  • keep larger cleanup and redesign work out of scope for this PR; track them separately in #987 and #989

Supported boundary

  • supported:
    • safe whole-row reentry on the bounded subset
    • carried scalar projection/order on the carried alias
  • explicit failfast:
    • cross-alias carried filters
    • fresh row-seeded reentry
    • shapes that rely on prefix WITH row ordering surviving into a multi-row trailing MATCH

Validation

  • local static checks:
    • python -m py_compile graphistry/compute/gfql_unified.py graphistry/compute/gfql/cypher/lowering.py graphistry/tests/compute/test_gfql.py graphistry/tests/compute/gfql/cypher/test_lowering.py
    • ruff check --no-cache graphistry/compute/gfql_unified.py graphistry/compute/gfql/cypher/lowering.py graphistry/tests/compute/test_gfql.py graphistry/tests/compute/gfql/cypher/test_lowering.py
  • local targeted tests:
    • PYTHONPATH=. pytest -q graphistry/tests/compute/test_gfql.py -k 'reentry'
    • PYTHONPATH=. pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k 'reentry'
  • local broad touched-file sanity:
    • PYTHONPATH=. pytest -q graphistry/tests/compute/test_gfql.py graphistry/tests/compute/gfql/cypher/test_lowering.py
    • result: 487 passed, 47 skipped
  • hosted CPU CI:
    • gh pr checks 975
    • result: fully green on head b4f730fbd
  • targeted GPU validation:
    • ssh dgx-spark shared-checkout remote worktree
    • official RAPIDS 26.02 cuda13
    • bounded-reentry cudf slice result: 7 passed in 3.18s

Companion / follow-ons

  • companion sibling bookkeeping PR:
    • graphistry/tck-gfql#12 test: refresh direct cypher support after rebase
  • architecture follow-ons kept out of this PR:
    • #987 explicit ReentryPlan / hidden-column-handshake cleanup
    • #989 broader row-carrier IR direction

Notes

  • this PR intentionally stays narrower than a generic WITH or row-carrier redesign
  • the remaining significant cleanup is architectural, not required to safely land the bounded-reentry feature in this branch

@lmeyerov lmeyerov changed the title fix: stabilize with-where scope projection fix: extend bounded cypher reentry carrier Mar 30, 2026
@lmeyerov lmeyerov force-pushed the feat/cypher-master-tck-coverage-frontier branch 3 times, most recently from b56cdd2 to d5ea36b Compare March 31, 2026 04:03
@lmeyerov lmeyerov force-pushed the feat/cypher-master-tck-coverage-frontier branch from e4f7d32 to ff94129 Compare March 31, 2026 06:53
@lmeyerov lmeyerov force-pushed the feat/cypher-master-tck-coverage-frontier branch from e9c5bb3 to f0edcb2 Compare March 31, 2026 07:13
@lmeyerov lmeyerov merged commit b5c11c6 into master Mar 31, 2026
93 of 94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant